New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no-extra-parens autofix with in
in a for-loop init (fixes #11706)
#11848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
An ESLint team member will look at this issue soon
label
Jun 16, 2019
mysticatea
reviewed
Jun 18, 2019
mysticatea
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
and removed
triage
An ESLint team member will look at this issue soon
labels
Jun 18, 2019
The following is done in this commit:
While doing this I've also found two possible bugs (missing checks) on |
mysticatea
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much!
This was referenced Aug 27, 2019
This was referenced Sep 12, 2019
This was referenced Nov 9, 2019
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix: #11706
What changes did you make? (Give an overview)
In the
no-extra-parens
rule, keep parens if necessary when anin
expression is in a for-loop initializer.For example, the following will be treated as a correct code (not reported):
Removing parens would produce SyntaxError. Each line would be treated as an invalid for-in loop.
Also, this change is trying to minimize false negatives, i.e. to remove really 'extra' parens.
For example, the following:
would be fixed to:
Is there anything you'd like reviewers to focus on?