Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: removed '>' prefix from from docs/working-with-rules #11818

Merged
merged 2 commits into from Jun 8, 2019
Merged

Docs: removed '>' prefix from from docs/working-with-rules #11818

merged 2 commits into from Jun 8, 2019

Conversation

AlokTakshak
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)
removed unnecessary > from docs

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 8, 2019
@AlokTakshak AlokTakshak changed the title removed '>' prefix from from docs/working-with-rules docs : removed '>' prefix from from docs/working-with-rules Jun 8, 2019
@AlokTakshak AlokTakshak changed the title docs : removed '>' prefix from from docs/working-with-rules Docs - removed '>' prefix from from docs/working-with-rules Jun 8, 2019
@AlokTakshak
Copy link
Contributor Author

@btmills

@AlokTakshak AlokTakshak changed the title Docs - removed '>' prefix from from docs/working-with-rules Docs: removed '>' prefix from from docs/working-with-rules Jun 8, 2019
btmills
btmills approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AlokTakshak!

platinumazure
platinumazure approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Thank you @btmills for pointing out that this change needed to happen in ESLint itself, as well.

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jun 8, 2019
@platinumazure platinumazure merged commit 20908a3 into eslint:master Jun 8, 2019
@btmills btmills mentioned this pull request Jun 10, 2019
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 6, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlokTakshak @platinumazure @btmills