Fix: no-octal should report NonOctalDecimalIntegerLiteral (fixes #11794) #11805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples: 08, 018, 08.1
eslint-deprecated
bot
added
the
triage
platinumazure
added
accepted
ilyavolodin
approved these changes
Jun 8, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples: 08, 018, 08.1
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11794
What changes did you make? (Give an overview)
Reference: ECMAScript Additional Syntax Numeric Literals
no-octal rule used to report all LegacyOctalIntegerLiteral literals (00, 01, 071...) and only some NonOctalDecimalIntegerLiteral literals (018...).
The rule didn't report NonOctalDecimalIntegerLiteral literals that start with 08 or 09.
With this fix, the rule will report all LegacyOctalIntegerLiteral and all NonOctalDecimalIntegerLiteral literals as well as all DecimalLiteral literals that contain them (e.g. 08.1, 08e1...).
Is there anything you'd like reviewers to focus on?