Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: overrides handle relative paths as expected (fixes #11577) #11799

Merged
merged 1 commit into from Jun 5, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #11577

What changes did you make? (Give an overview)

This PR fixes overrides[].files and overrides[].excludedFiles to handle ./ as expected.

The change is below. Especially, we newly can specify ./*.js-like patterns that match with the files in the root directory but not in subdirectories.

Pattern FilePath Before After Fixed
*.js foo.js true true
*.js dir/foo.js true true
./*.js foo.js false true
./*.js dir/foo.js false false
dir/*.js foo.js false false
dir/*.js dir/foo.js true true
./dir/*.js foo.js false false
./dir/*.js dir/foo.js false true

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 3, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mysticatea mysticatea merged commit 21f3131 into master Jun 5, 2019
@mysticatea mysticatea deleted the issue11577 branch June 5, 2019 09:06
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 3, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envs in overrides was not applied
5 participants