Fix: fails the test case if autofix made syntax error (fixes #11615) #11798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
bug
mysticatea
changed the title
aladdin-add
reviewed
Jun 4, 2019
aladdin-add
approved these changes
Jun 4, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix #11615
What changes did you make? (Give an overview)
This PR fixes
RuleTesterto fail the test case if autofix made syntax errors.Additionally,
RuleTester.describeandRuleTester.itpermanently intests/lib/rule-tester/rule-tester.js. This side-effect had confusedtests/lib/rules/*.jsas using the stub functions to test rules.I have noticed that
errorsproperty with a number allows syntax errors. Some of our tests depend on the behavior in order to use syntax error in rule's tests (E.g. tests/lib/rules/spaced-comment.js#L577-L589). I'm not sure if it's intentional, but I left it as is.I wonder if we should deprecate the
errorsproperty with a number. It causes false negatives such as tests/lib/rules/complexity.js#L84.Is there anything you'd like reviewers to focus on?
Nothing in particular.