Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show custom message for namespace import (fixes #11580) #11791

Merged
merged 1 commit into from Jun 2, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented May 30, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Fixes #11580 .

Is there anything you'd like reviewers to focus on?
Nothing.

@g-plane g-plane added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels May 30, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit cb1922b into master Jun 2, 2019
@platinumazure
Copy link
Member

Merged. Thanks for contributing!

@g-plane g-plane deleted the issue-11580 branch June 2, 2019 23:54
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 30, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-restricted-imports: message is ignored for star-imports when importNames is defined
3 participants