Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix typo in blog post template (fixes #11614) #11782

Merged
merged 1 commit into from May 31, 2019
Merged

Conversation

kaicataldo
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

As mentioned in #11614, there is a missing space in the blog post template when the release is semver-major.

What changes did you make? (Give an overview)
Added a space in the template.

Is there anything you'd like reviewers to focus on?
Nothing in particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 29, 2019
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process bug ESLint is working incorrectly and removed triage An ESLint team member will look at this issue soon labels May 29, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ilyavolodin ilyavolodin merged commit ad4b048 into master May 31, 2019
@ilyavolodin ilyavolodin deleted the fixes11614 branch May 31, 2019 17:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 28, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants