Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: improve reported location of arrow-parens (fixes #11773) #11775

Merged
merged 1 commit into from May 30, 2019
Merged

Update: improve reported location of arrow-parens (fixes #11773) #11775

merged 1 commit into from May 30, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented May 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule

What changes did you make? (Give an overview)
Fixes #11773

Is there anything you'd like reviewers to focus on?
Maybe no.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 27, 2019
@g-plane g-plane added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 27, 2019
platinumazure
platinumazure approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

aladdin-add
aladdin-add approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 9590587 into master May 30, 2019
@g-plane g-plane deleted the issue-11773 branch May 30, 2019 02:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 27, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the report location of arrow-paren
5 participants
@g-plane @platinumazure @ilyavolodin @kaicataldo @aladdin-add