Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the report location of arrow-paren #11773

Closed
golopot opened this issue May 26, 2019 · 3 comments · Fixed by #11775 · May be fixed by Omrisnyk/npm-lockfiles#130
Closed

Improve the report location of arrow-paren #11773

golopot opened this issue May 26, 2019 · 3 comments · Fixed by #11775 · May be fixed by Omrisnyk/npm-lockfiles#130
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@golopot
Copy link
Contributor

golopot commented May 26, 2019

What rule do you want to change?
arrow-paren

Currently the reported node is the whole function. It makes sense to change the reported node to the parameter node.

/* eslint arrow-parens: [2] */

// current report location
const f = a => a + a + a;
//        ~~~~~~~~~~~~~~ Error: needs parens.

// proposed report location
const f = a => a + a + a;
//        ~              Error: needs parens.

demo link

Are you willing to submit a pull request to implement this change?
yes

@golopot golopot added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules triage An ESLint team member will look at this issue soon labels May 26, 2019
@not-an-aardvark
Copy link
Member

Thanks for the proposal. This seems like a worthwhile change to me.

@not-an-aardvark not-an-aardvark added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 26, 2019
@platinumazure
Copy link
Member

I agree this should be done. I'll champion this change.

@eslint/eslint-team This needs one more 👍 to be accepted.

@platinumazure platinumazure self-assigned this May 27, 2019
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 27, 2019
@not-an-aardvark
Copy link
Member

This is now accepted.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 27, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
3 participants