Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove incorrect comment #11769

Merged
merged 2 commits into from May 27, 2019
Merged

Chore: remove incorrect comment #11769

merged 2 commits into from May 27, 2019

Conversation

aladdin-add
Copy link
Member

it is no longer needed, as #11742 get merged. :)

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

not really.

it is no longer needed, as #11742 get merged. :)
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 26, 2019
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm happy if you update the JSDoc comment @returns {Rule} ... to @returns {Rule|null} ... additionally.

@aladdin-add aladdin-add merged commit 8eaa9b2 into master May 27, 2019
@aladdin-add aladdin-add deleted the chore/remove-comment branch May 27, 2019 03:46
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 24, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants