Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add table of contents in readme #11765

Merged
merged 1 commit into from May 25, 2019
Merged

Docs: add table of contents in readme #11765

merged 1 commit into from May 25, 2019

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented May 24, 2019 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
image

@aladdin-add aladdin-add added enhancement This change enhances an existing feature of ESLint documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 24, 2019
platinumazure
platinumazure approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Probably good to get more eyes on this but looks reasonable to me.

@ilyavolodin ilyavolodin merged commit 1374be4 into eslint:master May 25, 2019
@aladdin-add aladdin-add deleted the docs-table branch May 26, 2019 01:05
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 22, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aladdin-add @platinumazure @ilyavolodin