Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add about RuleTester's parser to migration guide (fixes #11728) #11761

Merged
merged 1 commit into from May 25, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update (fixes #11728)

What changes did you make? (Give an overview)

This PR updates the migration guide to describe the change that RuleTester disallows parser property with package names.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels May 24, 2019
@mysticatea mysticatea added this to Implemented, pending review in v6.0.0 May 24, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ilyavolodin ilyavolodin merged commit 45bd336 into master May 25, 2019
v6.0.0 automation moved this from Implemented, pending review to Done May 25, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 22, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 22, 2019
@mysticatea mysticatea deleted the issue11728 branch April 14, 2020 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
No open projects
v6.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

[6.0.0-alpha.1] RuleTester fails tests if parser property is a package name
4 participants