Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fixes typo in JSDoc in timing package #11755

Merged
merged 1 commit into from May 23, 2019

Conversation

dimitropoulos
Copy link
Contributor

The function in question does not return a string although I certainly understand how it feels like it does since what it actually does is print the desired string to the console.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this!

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 22, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit ec105b2 into eslint:master May 23, 2019
@dimitropoulos dimitropoulos deleted the patch-2 branch May 29, 2019 15:23
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 20, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants