Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: updated no-proto rule (fixes #11743) #11746

Merged
merged 1 commit into from May 23, 2019
Merged

Docs: updated no-proto rule (fixes #11743) #11746

merged 1 commit into from May 23, 2019

Conversation

fasttime
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#11743

What changes did you make? (Give an overview)

  • Added instructions to change an object's prototype with Object.setPrototypeOf.
  • Disambiguated getPrototypeOf to Object.getPrototypeOf.
  • Some new code examples.
  • Revised "When Not To Use It" note, as getPrototypeOf is widely supported today.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 21, 2019
@fasttime
Copy link
Member Author

I also added an example of correct code to show that __proto__ is still allowed in object literal syntax when the no-proto rule is active. I hope it is fine.

@g-plane g-plane added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 21, 2019
g-plane
g-plane approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

aladdin-add
aladdin-add approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

platinumazure
platinumazure approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit e45cc3f into eslint:master May 23, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 20, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

@g-plane g-plane g-plane approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fasttime @platinumazure @aladdin-add @g-plane