Breaking: stricter rule config validating (fixes #9505) #11742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
enhancement
mysticatea
suggested changes
May 20, 2019
mysticatea
suggested changes
May 22, 2019
tests/lib/cli-engine.js
Outdated
| @@ -1370,8 +1370,8 @@ describe("CLIEngine", () => { | |||
| assert.strictEqual(report.results.length, 1); | |||
| assert.strictEqual(report.results[0].messages.length, 1); | |||
| assert.strictEqual(report.results[0].messages[0].ruleId, "missing-rule"); | |||
| assert.strictEqual(report.results[0].messages[0].severity, 1); | |||
| assert.strictEqual(report.results[0].messages[0].message, "Definition for rule 'missing-rule' was not found"); | |||
| assert.strictEqual(report.results[0].messages[0].severity, 2); | |||
There was a problem hiding this comment.
I'm OK for this change, but we have to add it to the migration guide because it can newly fail CI builds.
aladdin-add
force-pushed
the
issue9505
branch
3 times, most recently
from
6ef06fa
to
98bda3c
Compare
aladdin-add
changed the title
mysticatea
moved this from Implemented, pending review
to Accepted, ready to implement
in v6.0.0
aladdin-add
changed the title
aladdin-add
changed the title
aladdin-add
changed the title
|
I think it's ready to be reviewed! 😄 ptal. @mysticatea |
to fix issue eslint#9505, it made a refactor and introduced a few changes to make validating more consistent: * will report a linting error when enable/disable a non-existent in inline comment. * will throw an error, if config a non-existent rule to non-zero value. * fixes problem loc in some cases
mysticatea
approved these changes
May 24, 2019
|
and please note: this PR will break |
mysticatea
moved this from Accepted, ready to implement
to Implemented, pending review
in v6.0.0
ilyavolodin
approved these changes
May 25, 2019
|
@aladdin-add Could you also add information into migration guide please? |
|
@aladdin-add Since this is the last breaking issue left in this release, I'm going to merge it as is. Could you open a new PR with updated migration guide please? We will merge it with the next release. |
aladdin-add
added a commit
that referenced
this pull request
May 26, 2019
it is no longer needed, as #11742 get merged. :)
|
Well, we need to update our migration guide. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
What is the purpose of this pull request? (put an "X" next to item)
[x] Add something to the core
What changes did you make? (Give an overview)
fixes #9505
Is there anything you'd like reviewers to focus on?
/*eslint-enable foo*//*eslint-disable(-line) foo*//*eslint foo: 0*/{rules: {foo: 0}}{rules: {foo: 1}getRule()will not return a stub rule if the rule cannot be loaded.Previously, the
ruleMapper.getRule()will return a stub rule, when the rule is not defined. it was really counter-intuitive and confusing.After this change, it will return
nullin this case. As a result it will report a linting error, and has no effect to the final config: