Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: eslint-config-eslint require node >= 8 #11718

Merged
merged 1 commit into from May 23, 2019
Merged

Chore: eslint-config-eslint require node >= 8 #11718

merged 1 commit into from May 23, 2019

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented May 14, 2019 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
I presume there is no much need to target the EOL node versions. and it seems too wordy to add something like "eslint-plugin-node": "^6.0.1 || ^7.0.1 || ^8.0.0 || ^9.0.0..." :)

@aladdin-add aladdin-add added infrastructure Relates to the tools used in the ESLint development process evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion chore This change is not user-facing labels May 14, 2019
platinumazure
platinumazure approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mysticatea
mysticatea reviewed May 14, 2019
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change the label to Breaking: because it's a breaking change for eslint-plugin-eslint?

@not-an-aardvark
Copy link
Member

I think that would cause the ESLint release to be Breaking. The release type for eslint-config-eslint is selected manually without looking at commit messages.

@mysticatea
Copy link
Member

I got it. Thank you for your answer!

mysticatea
mysticatea approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Just a note, we should remember using a new major version when we release the next eslint-config-eslint.

@mysticatea mysticatea added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 22, 2019
@aladdin-add aladdin-add merged commit 15c6c63 into master May 23, 2019
@aladdin-add aladdin-add deleted the aladdin-add-patch-1 branch May 23, 2019 06:58
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 20, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@mysticatea mysticatea mysticatea approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aladdin-add @not-an-aardvark @mysticatea @platinumazure