New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add classname attribute to JUnit testcase (refs #11068) #11683
New: Add classname attribute to JUnit testcase (refs #11068) #11683
Conversation
Moved changes to eslint/eslint#11683
Moved changes to eslint/eslint#11683
@not-an-aardvark @platinumazure Is there anything missing with this PR that I can help? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I would like another team member (or more than one) to review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. Can you rebase on the latest master please?
9a5e73c
to
a7449e9
Compare
Thank you @ilyavolodin. Rebased. |
Awesome! @hspazio |
What is the purpose of this pull request? (put an "X" next to item)
This PR is a follow up from the discussion in issue #11068.
With this change we are adding
classname
attribute to the<testcase>
item.[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Add new attribute to JUnit formatter
What changes did you make? (Give an overview)
The value of
classname
is defined as the file path without extension.Similar implementation to TSlint: palantir/tslint#4327
example:
Is there anything you'd like reviewers to focus on?
Does this schema also need to be updated? https://eslint.org/docs/user-guide/formatters/#junit