Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endColumn to no-useless-escape #11629

Closed
YodaDaCoda opened this issue Apr 18, 2019 · 2 comments · Fixed by #11790 · May be fixed by Omrisnyk/npm-lockfiles#130
Closed

Add endColumn to no-useless-escape #11629

YodaDaCoda opened this issue Apr 18, 2019 · 2 comments · Fixed by #11790 · May be fixed by Omrisnyk/npm-lockfiles#130
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@YodaDaCoda
Copy link

What rule do you want to change? no-useless-escape

Does this change cause the rule to produce more or fewer warnings? no

How will the change be implemented? (New option, new default behavior, etc.)? New default behaviour: return an endColumn

Please provide some example code that this change will affect:

var regex = /[\.]/;

What does the rule currently do for this code? Currently, the rule correctly detects an issue with the code. However, since the rule doesn't return an endColumn, my IDE (Atom) highlights until the end of the line in this example (from my testing, I think it highlights until the end of the line, or until the next \), which makes for a rather confusing UX.

What will the rule do after it's changed? Return an endColumn

Are you willing to submit a pull request to implement this change? No

@YodaDaCoda YodaDaCoda added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules triage An ESLint team member will look at this issue soon labels Apr 18, 2019
@platinumazure platinumazure added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Apr 18, 2019
@platinumazure
Copy link
Member

Thanks @YodaDaCoda for creating a new issue!

Personally I'm on the fence about whether this should be a bug fix or an enhancement. In any event, I will champion this change.

@platinumazure platinumazure self-assigned this Apr 18, 2019
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 29, 2019
@kaicataldo
Copy link
Member

This is now accepted.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 30, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
3 participants