Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuleTester should report syntax error of fixed code #11615

Closed
mysticatea opened this issue Apr 13, 2019 · 2 comments · Fixed by #11798 · May be fixed by Omrisnyk/npm-lockfiles#130
Closed

RuleTester should report syntax error of fixed code #11615

mysticatea opened this issue Apr 13, 2019 · 2 comments · Fixed by #11798 · May be fixed by Omrisnyk/npm-lockfiles#130
Assignees
@mysticatea
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint

Comments

@mysticatea
Copy link
Member

The version of ESLint you are using.

  • master

The problem you want to solve.

I found RuleTester doesn't report any errors even if autofix makes a syntax error in #11579.

image

I expected above test results to be "A fatal parsing error occurred in autofix: Parsing error: ..." rather than "Output is incorrect".

Your take on the correct solution to problem.

RuleTester makes failing if autofix made a syntax error.

Are you willing to submit a pull request to implement this change?

Yes.
@mysticatea mysticatea added bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features breaking This change is backwards-incompatible evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Apr 13, 2019
@mysticatea mysticatea added this to Memorandum in v7.0.0 Apr 13, 2019
@mysticatea mysticatea self-assigned this Apr 13, 2019
@kaicataldo
Copy link
Member

This feels like a bug - I wonder if we need to wait for a major release to fix this?

@mysticatea
Copy link
Member Author

I'm fine to fix it as a bug.

@mysticatea mysticatea removed this from Memorandum in v7.0.0 Jun 3, 2019
@mysticatea mysticatea added accepted There is consensus among the team that this change meets the criteria for inclusion and removed breaking This change is backwards-incompatible evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 3, 2019
mysticatea added a commit that referenced this issue Jun 3, 2019
@mysticatea
Fix: fails the test case if autofix made syntax error (fixes #11615)
7e7caf1
@mysticatea mysticatea mentioned this issue Jun 3, 2019
Merged
mysticatea added a commit that referenced this issue Jun 5, 2019
@mysticatea
Fix: fails the test case if autofix made syntax error (fixes #11615) (#…
5509cdf 
…11798)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 3, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mysticatea mysticatea

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
None yet
Milestone
No milestone
2 participants
@mysticatea @kaicataldo