New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: restructure files #11555
Chore: restructure files #11555
Conversation
359eb18
to
5e1dfde
Compare
573e5d5
to
07d5069
Compare
07d5069
to
a5f8e84
Compare
Hi. I rebased this PR. I'd like to discuss the direction.
|
# Conflicts: # Makefile.js # conf/eslint-recommended.js # lib/built-in-rules-index.js # tools/eslint-fuzzer.js
What this PR does:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good move! LGTM, but a few non-blocking questions. Thanks!
# Conflicts: # tools/eslint-fuzzer.js
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain: moving files.
What changes did you make? (Give an overview)
This PR moves files to the new directory structure. The purpose of this PR is to make clear what functionality use which files. Especially, I wanted to reduce the many
util
files.The new structure is:
lib/init
... The files are to implement--init
functionality.lib/cli-engine
... The files are to implementCLIEngine
public API.lib/linter
... The files are to implementLinter
public API.lib/source-code
... The files are to implementSourceCode
public API.lib/rule-tester
... The files are to implementRuleTester
public API.lib/rules
... The files are to implement core rules.lib/shared
... The files are shared with multiple functionality.Is there anything you'd like reviewers to focus on?
Is this move nice?