Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use nyc instead of istanbul #11532

Merged
merged 2 commits into from Mar 22, 2019
Merged

Chore: use nyc instead of istanbul #11532

merged 2 commits into from Mar 22, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain

What changes did you make? (Give an overview)

This PR switch from istanbul to nyc the official successor of istanbul CLI.

This is needed in order to use newer ES syntaxes.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added infrastructure Relates to the tools used in the ESLint development process chore This change is not user-facing labels Mar 20, 2019
Makefile.js Outdated Show resolved Hide resolved
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just left one question.

Makefile.js Outdated Show resolved Hide resolved
Makefile.js Outdated Show resolved Hide resolved
@mysticatea mysticatea merged commit 4fe7eb7 into master Mar 22, 2019
@mysticatea mysticatea deleted the nyc branch March 22, 2019 23:12
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 19, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants