Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled release for March 29th, 2019 #11526

Closed
eslint-deprecated bot opened this issue Mar 18, 2019 · 2 comments
Closed

Scheduled release for March 29th, 2019 #11526

eslint-deprecated bot opened this issue Mar 18, 2019 · 2 comments
Assignees
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion release This issue contains information about a scheduled ESLint release

Comments

@eslint-deprecated
Copy link

eslint-deprecated bot commented Mar 18, 2019

The scheduled release on Friday, March 29th, 2019 is assigned to:

Please use this issue to document how the release went, any problems during the release, and anything the team might want to know about the release process. This issue should be closed after all patch releases have been completed (or there was no patch release needed).

Resources:

@eslint-deprecated eslint-deprecated bot added release This issue contains information about a scheduled ESLint release tsc agenda This issue will be discussed by ESLint's TSC at the next meeting labels Mar 18, 2019
@ilyavolodin ilyavolodin self-assigned this Mar 28, 2019
@btmills btmills removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Mar 28, 2019
@platinumazure platinumazure added the patch release pending A new release just shipped. No enhancements will be merged for a few days in case a patch is needed label Mar 30, 2019
@platinumazure
Copy link
Member

ESLint v5.16.0 has been released.

We ran into some trouble because #11551 accidentally forgot to take into account the gensite process in our Makefile (which calls the formatters from CLIEngine, without passing in the new data object with rules metadata). This was fixed by #11567. We also decided to implement #11566 as any users who use the html formatter through CLIEngine would also have been broken.

Adding unit tests to some of our Makefile steps has been on our list for a long time. Although that is a complex task, unit tests around the formatter examples section of gensite would have allowed us to catch this issue before merging.

Release is in good shape. Please merge semver-patch PRs only until we have evaluated whether a patch release is needed on Monday due to regressions.

@platinumazure
Copy link
Member

No regressions were identified, so we are declaring the 5.16.0 release cycle closed.

@eslint/eslint-team Please feel free to merge semver-minor PRs. Additionally, since we are now ready to do major release candidates, please feel free to merge semver-major PRs that are ready to go.

@platinumazure platinumazure removed the patch release pending A new release just shipped. No enhancements will be merged for a few days in case a patch is needed label Apr 1, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 29, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion release This issue contains information about a scheduled ESLint release
Projects
None yet
Development

No branches or pull requests

3 participants