Chore: Update README to pull in reviewer data #11506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
ilyavolodin
approved these changes
Mar 14, 2019
|
Some linting errors needs to be fixed before this can be merged. |
|
Oops, thanks for pointing that out. Pushing a fixed version. |
|
It seems like there are still some linting errors in the readme. |
platinumazure
approved these changes
Mar 15, 2019
platinumazure
added
enhancement
|
Thanks, I'll get that fixed. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Updates the script that builds the README to include data from the reviewers team.
What changes did you make? (Give an overview)
Updated the
update-readme.jsscript to include reviewers. This involved some refactoring to make things a bit easier to manage. I'm now using some EJS to do the overall layout of the team section.Is there anything you'd like reviewers to focus on?
Is everything clear?