Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: copy bundled espree to website directory #11478

Merged
merged 1 commit into from Mar 6, 2019
Merged

Build: copy bundled espree to website directory #11478

merged 1 commit into from Mar 6, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Mar 5, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Other

What changes did you make? (Give an overview)
Copy the bundled espree, which we forgot.

Is there anything you'd like reviewers to focus on?
Nope.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 5, 2019
@g-plane g-plane added build This change relates to ESLint's build process and removed triage An ESLint team member will look at this issue soon labels Mar 5, 2019
not-an-aardvark
not-an-aardvark approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

It might also be worth opening a PR on eslint.github.io that adds the espree file, so that we don't need to wait until the next release.

@g-plane
Copy link
Member Author

g-plane commented Mar 5, 2019

I'll do that!

@g-plane g-plane mentioned this pull request Mar 5, 2019
Merged
aladdin-add
aladdin-add approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 34a5382 into master Mar 6, 2019
@not-an-aardvark not-an-aardvark deleted the copy-espree branch March 6, 2019 08:07
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 28, 2019
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 3, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion build This change relates to ESLint's build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@g-plane @platinumazure @ilyavolodin @not-an-aardvark @aladdin-add