Fix: avoid creating invalid regex in no-warning-comments (fixes #11471) #11472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
See #11471
What changes did you make? (Give an overview)
5018378 changed the codebase to use unicode regexes almost everywhere, with the exception of places where regexes are constructed from user input. However, two issues occurred to cause a bug:
no-warning-comments
rule were changed to be unicode regexes even though those regexes were constructed from user input.no-warning-comments
rule dynamically creates regexes with unnecessary escape characters, and unnecessary escape characters are invalid in unicode regexes.This commit fixes the first issue. The second issue isn't a problem on its own, but it will need to be fixed in order to implement #11423.
Is there anything you'd like reviewers to focus on?
Nothing in particular