Build: bundle espree (fixes eslint/eslint.github.io#546) #11467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
bug
aladdin-add
force-pushed
the
build/espree
branch
from
77852ef
to
4d85aa2
Compare
aladdin-add
changed the title
g-plane
reviewed
Mar 3, 2019
Co-Authored-By: aladdin-add <weiran.zsd@outlook.com>
|
Thanks for the PR! I think the bot just never had to worry about cross-repository fixes before- we could certainly enhance to allow that case. I wouldn't have a problem merging this with the commit message "error", assuming any other issues are fixed. |
ilyavolodin
approved these changes
Mar 3, 2019
not-an-aardvark
approved these changes
Mar 4, 2019
g-plane
approved these changes
Mar 5, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
fixes eslint/archive-website#546
Is there anything you'd like reviewers to focus on?
the commit message checking failing -- how to fix a cross-repo issue?