Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove devDependency common-tags #11455

Merged
merged 1 commit into from Mar 1, 2019

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Mar 1, 2019

this is following #11453.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
no.

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Mar 1, 2019
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit aaba636 into master Mar 1, 2019
@not-an-aardvark not-an-aardvark deleted the chore/remove-common-tags branch March 1, 2019 07:33
not-an-aardvark added a commit that referenced this pull request Mar 1, 2019
not-an-aardvark added a commit that referenced this pull request Mar 1, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 29, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants