Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add utils for rule tests #11453

Merged
merged 2 commits into from Mar 1, 2019

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Feb 28, 2019

some functions can be reused in rule tests (like unIndent). does it make sense?

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
no.

@aladdin-add aladdin-add added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion chore This change is not user-facing labels Feb 28, 2019
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I think we could also use this to replace the common-tags dependency in tools/update-readme.js.

@aladdin-add
Copy link
Member Author

haven't noticed that, will do it in another PR.

@aladdin-add aladdin-add merged commit ee88475 into eslint:master Mar 1, 2019
@aladdin-add aladdin-add deleted the chore/test-utils branch March 1, 2019 03:49
aladdin-add added a commit that referenced this pull request Mar 1, 2019
not-an-aardvark pushed a commit that referenced this pull request Mar 1, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 29, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants