Update: Add never option for new-parens (refs #10034)

[pfgithub]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#10034 was closed automatically for a lack of interest, I'm not sure if this functionality is wanted.

What changes did you make? (Give an overview)

Added an argument to new-parens for always or never. The default with no arguments keeps the same functionality. Added tests for the never option and updated documentation.

Is there anything you'd like reviewers to focus on?

The fixer will always put parenthesis even when they're not required.

What rule do you want to change?

new-parens

Does this change cause the rule to produce more or fewer warnings?

No

How will the change be implemented? (New option, new default behavior, etc.)?

Adds an option for enforcing or disallowing parenthesis on constructors with no arguments using new. Default behavior stays the same.

Please provide some example code that this change will affect:

Examples of incorrect code for this rule with the "never" option:

/*eslint new-parens: ["error", "never"]*/

var person = new Person();
var person = new (Person)();

Examples of correct code for this rule with the "never" option:

/*eslint new-parens: ["error", "never"]*/

var person = new Person;
var person = (new Person);
var person = new Person("Name");

What does the rule currently do for this code?

Errors because the arguments are invalid.

What will the rule do after it's changed?

The argument will no longer be invalid.

[ilyavolodin]

@eslint/eslint-team We completely lost track of this PR, does anyone else wants to support it/champion it?

[platinumazure]

I'll champion. Just needs one more 👍 from the team.

[platinumazure]

It would be good to have some tests explicitly using the "always" option (to make sure they behave the same as no option).

Also left a few other suggestions.

[pfgithub]

I added a few tests for explicitly using "always" and I also added some to make sure that "never" allows parenthesis when there are arguments.

I also fixed the comment and changed the message id and message.

[platinumazure]

The ESLint team still needs to accept this before merging, but the implementation looks good to me. Thanks for contributing!

[ilyavolodin]

@eslint/eslint-team Need just one more +1 vote for this. It's time to either accept it, or close this issue.

[kaicataldo]

Thanks for contributing to ESLint!