New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes #7145)

[richie3366]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?
padded-blocks

Does this change cause the rule to produce more or fewer warnings?
Less

How will the change be implemented? (New option, new default behavior, etc.)?
New option: allowSingleLineBlocks property in a new object parameter
It will allow to use single line blocks (as described in #7145)

Please provide some example code that this change will affect:
from

if (cond) {

  doSomething();

}

let myObj = {
  myFunc (test) {

    return !test;

  }
}

to

if (cond) { doSomething(); }

let myObj = {
  myFunc (test) { return !test; }
}

What does the rule currently do for this code?
Warning / Error: "Block must be padded by blank lines."

What will the rule do after it's changed?
Emits no warning if using {allowSingleLineBlocks: true} option (as second parameter)

What changes did you make? (Give an overview)

• implemented the change in the rule sourcecode

Is there anything you'd like reviewers to focus on?

• write test cases
• update docs

[jsf-clabot]

All committers have signed the CLA.

[kaicataldo]

@richie3366 Would you mind fixing the linting issue as well as the commit message so that we can review this? Thanks!

[richie3366]

Oh, yes, sorry, it seems my editor doesn't want to let the linter work on this project, kinda paradoxical... 🤔

I hope it's all good for you.
Thanks!

[not-an-aardvark]

Hi, thanks for the pull request. May you please add tests and documentation for the new option?

[richie3366]

Whoops, could someone tell me what's wrong with my commit message? I tried to respect the tag & length rule, but maybe I missed something(?) Thx

Ok, it was the PR title, nvm.

[richie3366]

@not-an-aardvark I've made the requested changes through the commit 193fb91 but it seems that they've not been detected. Could you please take a look (and maybe review the PR if you want & can)? Thanks

Stale review