Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoconfig from --init #11235

Closed
btmills opened this issue Jan 3, 2019 · 2 comments
Closed

Remove autoconfig from --init #11235

btmills opened this issue Jan 3, 2019 · 2 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion

Comments

@btmills
Copy link
Member

btmills commented Jan 3, 2019

The autoconfig portion of #11105 is being moved into this new issue after discussion in today's TSC meeting. The rest of this description was originally written by @nzakas in #11105:

The problem you want to solve.

The --init behavior has remained pretty consistent since it was first launched. At that point, we didn't know what options people wanted and the number of rules was very small. It seems like the current questions don't make sense for how ESLint is used today. For example, forcing people to pick a style guide doesn't make sense for everyone and sends a message that ESLint is used primarily for styling. I'd like to update the behavior of --init to better reflect current users expectations and usage.

Your take on the correct solution to problem.

Remove autoconfig option. I'm not sure how people feel about this, but I'm skeptical that this option is used all that much thanks to the popularity of shareable configs. I'm in favor of removing it if others agree but have no problem leaving it in if people feel it's still helpful.

Are you willing to submit a pull request to implement this change?

Yes.

@btmills btmills added enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon core Relates to ESLint's core APIs and features cli Relates to ESLint's command-line interface evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed core Relates to ESLint's core APIs and features triage An ESLint team member will look at this issue soon labels Jan 3, 2019
@nzakas
Copy link
Member

nzakas commented Jan 9, 2019

I'm also in favor of removing it. I see very little discussion of autoconfig anywhere I look (issues, Twitter, StackOverflow) and I'm not sure it's working 100% correctly at this point (see #11099).

Autoconfig was originally created because we felt that most people would want to create a style guide that most closely matches what they already have, but in reality, it seems like most people take an existing style guide and tweak it to match what they want.

@eslint-deprecated eslint-deprecated bot added the auto closed The bot closed this issue label Feb 9, 2019
@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 9, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

No branches or pull requests

2 participants