constructor-super issue with constructors that use return and finally

[Neuroboy23]

The code below triggers the constructor-super rule, but I believe it should not. The only paths through this code either always call super and/or always exception out.

class A {}

class B extends A {
    constructor() {
        try {
            const result = super();
            return result;
        }
        finally {
        }
    }
}
// error  Lacked a call of 'super()' in some code paths  constructor-super

It also happens if there is a re-throwing catch clause and a finally.

class A {}

class B extends A {
    constructor() {
        try {
            const result = super();
            return result;
        }
        catch (e) {
            throw e;
        }
        finally {
        }
    }
}
// error  Lacked a call of 'super()' in some code paths  constructor-super

It does NOT happen if the finally clause isn't present.

class A {}

class B extends A {
    constructor() {
        try {
            const result = super();
            return result;
        }
        catch (e) {
            throw e;
        }
    }
}
// OK

It also does NOT happen if there's no return statement.

class A {}

class B extends A {
    constructor() {
        try {
            super();
        }
        finally {
        }
    }
}
// OK

Environment:

• OS: Windows 10
• Node: v10.11.0
• ESLint: v5.9.0
• NPM: v6.4.1
• Parser: eslint
• Configuration:

module.exports = {
    "root": true,
    "env": {
        "amd": true,
        "es6": true
    },
    "globals": {
        "define": true,
        "asyncDefine": true
    },
    "parserOptions": {
        "ecmaVersion": 2015,
        "ecmaFeatures": {
            "impliedStrict": true
        }
    },
    "extends": "eslint:recommended",
    "rules": {

        "for-direction": "error",
        "getter-return": "error",
        "no-constant-condition": ["error", { "checkLoops": false }],
        "no-extra-parens": "off",

        "accessor-pairs": "error",
        "array-callback-return": "error",
        "class-methods-use-this": "error",
        "complexity": ["error", 20],
        "consistent-return": "error",
        "curly": "error",
        "default-case": "error",
        "dot-location": ["error", "property"],
        "eqeqeq": "error",
        "no-alert": "error",
        "no-caller": "error",
        "no-div-regex": "error",
        "no-else-return": "error",
        "no-eq-null": "error",
        "no-eval": "error",
        "no-extend-native": "error",
        "no-extra-label": "error",
        "no-floating-decimal": "error",
        "no-implicit-globals": "error",
        "no-implied-eval": "error",
        "no-iterator": "error",
        "no-labels": "error",
        "no-loop-func": "error",
        "no-new": "error",
        "no-new-wrappers": "error",
        "no-octal-escape": "error",
        "no-redeclare": "off",
        "no-return-assign": ["error", "always"],
        "no-return-await": "error",
        "no-script-url": "error",
        "no-self-assign": "error",
        "no-self-compare": "error",
        "no-sequences": "error",
        "no-throw-literal": "error",
        "no-unmodified-loop-condition": "error",
        "no-unused-expressions": "error",
        "no-useless-call": "error",
        "no-useless-concat": "error",
        "no-useless-return": "error",
        "no-void": "error",
        "no-with": "error",
        "prefer-promise-reject-errors": "error",
        "require-await": "error",
        "wrap-iife": ["error", "any"],
        "yoda": "error",
        "strict": ["error", "never"],

        "no-shadow-restricted-names": "error",
        "no-undef-init": "error",
        "no-unused-vars": ["error", { "args": "none", "varsIgnorePattern": "^logger$" }],

        "brace-style": ["error", "stroustrup", { "allowSingleLine": true }],
        "comma-dangle": ["error", "only-multiline"],
        "comma-spacing": "error",
        "comma-style": "error",
        "computed-property-spacing": "error",
        "func-call-spacing": "error",
        "keyword-spacing": "error",
        "max-depth": ["error", 5],
        "max-len": ["error", 100 , { "ignoreComments": true, "ignoreUrls": true, "ignoreStrings": true }],
        "max-statements": "off",
        "max-statements-per-line": "error",
        "new-cap": ["error", { "capIsNewExceptionPattern": "^[A-Z0-9_]+$", "properties": false }],
        "new-parens": "error",
        "no-array-constructor": "error",

        "no-multiple-empty-lines": "error",
        "no-nested-ternary": "error",
        "no-new-object": "error",
        "no-tabs": "error",
        "no-trailing-spaces": "warn",
        "no-whitespace-before-property": "error",
        "object-curly-newline": ["error", { "consistent": true }],
        "operator-linebreak": ["error", "after", { "overrides": { "?": "after", ":": "after" } }],

        "quotes": ["error", "double"],
        "no-extra-semi": ["warn"],
        "semi": ["error", "always"],
        "semi-spacing": "error",
        "semi-style": "error",
        "space-before-blocks": "error",
        "space-in-parens": ["error", "never"],
        "space-infix-ops": ["error", { "int32Hint": true }],
        "space-unary-ops": "error",
        "switch-colon-spacing": "error",
        "template-tag-spacing": "error",

        "space-before-function-paren": ["error", {
            "anonymous": "ignore",
            "asyncArrow": "ignore",
            "named": "never",
        }],

        "spaced-comment": ["error", "always", {
            "markers": ["/"],
            "exceptions": ["/", "-", "=", "#"]
        }],
    }
};

[aladdin-add]

Thanks for the report!
seems a bug to me. Are you willing to submit a pull request to fix it? 😄

[Neuroboy23]

@aladdin-add I am willing to work on this, but I'm awaiting approval from my company. I will claim this issue when that approval happens, unless someone claims in first.

[not-an-aardvark]

This seems related to #7481.

[eslint-deprecated]

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.