Tests failing on current master

[aladdin-add]

see https://ci.appveyor.com/project/nzakas/eslint/builds/20097976

[nzakas]

Confirmed. This is blocking PRs right now.

[not-an-aardvark]

Based on the test failures this might have been caused by the recent release of flat-cache. However, I don't have time to look into it in more detail at the moment.

[nzakas]

I'll try to take a look in the few minutes of remaining energy I have.

[nzakas]

Related: #11052

[nzakas]

It looks like the contents of .eslintcache is now an array instead of an object, and all of the tests are failing because they are expecting the cache file to contain an object with keys that are the filenames.

I'm not sure that this has actually changed the functionality of CLIEngine, because we are reading from and writing to the cache using the API, whereas in the tests we are reading the cache file directly.

However, if the cache file format has changed, that will cause a problem for people who have an existing cache file and then upgrade or reinstall ESLint.

@royriojas any thoughts?

[royriojas]

hi @nzakas,

I recently released a new version of the flat-cache as a patch, which is in time used by file-entry-cache, but the unit tests passed in both flat-cache and file-entry-cache that's why I believe it was safe.

The newer flat-cache is now using flatted as it was changed in this PR. jaredwray/flat-cache#23

Will take some time to review if that might be interpreting/serializing differently the cache, as I said, I wouldn't expect it to happen as tests passed. But it might be we're lacking one test to protect against cases like this.

[royriojas]

I've reverted the upgrade of circular-json to flatted :( and published it as flat-cache@1.3.2

Will add a test for the eslint case before attempting to upgrade again

I verified master in eslint and tests pass just fine.

[nzakas]

Thanks @royriojas looks like we are in the clear now.

[aladdin-add]

closing, as the issue has been fixed.