Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build: Use karma-chrome-launcher to run tests (#10898)" #10973

Merged
merged 1 commit into from Oct 12, 2018

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This reverts commit 9bc3f7c. It seems to be causing the release build on Jenkins to fail.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 12, 2018
@not-an-aardvark not-an-aardvark merged commit 536611a into master Oct 12, 2018
@not-an-aardvark not-an-aardvark deleted the revert-chrome-headless branch October 12, 2018 19:24
aladdin-add added a commit that referenced this pull request Oct 17, 2018
aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Oct 17, 2018
aladdin-add added a commit that referenced this pull request Nov 7, 2018
not-an-aardvark pushed a commit that referenced this pull request Jan 4, 2019
* Revert "Revert "Build: Use karma-chrome-launcher to run tests (#10898)" (#10973)"

This reverts commit 536611a.

* Build: add devdeps puppeteer@1.9.0

* Chore: set the path to chromium binary
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 11, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants