Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo for no-unsafe-finally #10945

Merged
merged 1 commit into from Oct 9, 2018
Merged

Fix typo for no-unsafe-finally #10945

merged 1 commit into from Oct 9, 2018

Conversation

taueres
Copy link
Contributor

@taueres taueres commented Oct 9, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
The comment erroneously said 1 is returned but the value returned is 0.

@jsf-clabot
Copy link

jsf-clabot commented Oct 9, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 9, 2018
platinumazure
platinumazure approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Note to merger: Add "Docs:" prefix to commit summary.

not-an-aardvark
not-an-aardvark approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 95c4cb1 into eslint:master Oct 9, 2018
@taueres taueres deleted the fix-comment-unsafe-finally branch October 10, 2018 14:07
btmills added a commit that referenced this pull request Oct 12, 2018
@btmills
Revert "Docs: Fix typo for no-unsafe-finally (#10945)"
13d7ae5 
This reverts commit 95c4cb1.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 8, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taueres @jsf-clabot @platinumazure @not-an-aardvark