Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cannot read property 'range' of null error with one-var (#10937) #10938

Merged
merged 1 commit into from Oct 12, 2018

Conversation

jkrup
Copy link
Contributor

@jkrup jkrup commented Oct 8, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#10937

What changes did you make? (Give an overview)
If there is no tokenAfterDeclarator when mapping over the declarators, return null rather than attempt to access a property on the null object.

Is there anything you'd like reviewers to focus on?
Nothing in particular 馃槃

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 8, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (Would like another set of eyes on this before merging.)

@platinumazure platinumazure added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 8, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Waiting a bit longer before merging (in general, we usually leave bugfix PRs open for at least 48 hours), but this should get merged soon unless someone else raises an objection.

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jkrup! Merging this in for the release today.

@btmills btmills merged commit 543edfa into eslint:master Oct 12, 2018
btmills added a commit that referenced this pull request Oct 12, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 11, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants