Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add more test cases to space-infix-ops #10936

Merged
merged 1 commit into from Oct 7, 2018

Conversation

madbence
Copy link
Contributor

@madbence madbence commented Oct 7, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Added some test cases with more interesting ASTs.

Is there anything you'd like reviewers to focus on?

((a)) + ((b)) and (((a))) + (((b))) are especially interesting, because this is the only case when there are more than 5 tokens between a and b.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 7, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Oct 7, 2018
@not-an-aardvark not-an-aardvark merged commit fe8111a into eslint:master Oct 7, 2018
@madbence madbence deleted the space-infix-ops-add-tests branch October 8, 2018 15:16
btmills added a commit that referenced this pull request Oct 12, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 6, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants