Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update working-with-parsers link #10929

Merged
merged 1 commit into from Oct 8, 2018
Merged

Conversation

azeemba
Copy link
Contributor

@azeemba azeemba commented Oct 6, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
The file seems to have been renamed so updating the link to point to the new file.

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Oct 6, 2018

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 6, 2018
@azeemba azeemba changed the title Update working-with-parsers link Docs: Update working-with-parsers link Oct 6, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see the comment I left inline 😄

docs/developer-guide/README.md Outdated Show resolved Hide resolved
The file seems to have been renamed so updating the link too.
@platinumazure platinumazure added documentation Relates to ESLint's documentation core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 8, 2018
@platinumazure platinumazure merged commit 3dccac4 into eslint:master Oct 8, 2018
@platinumazure
Copy link
Member

Merged. Thanks @azeemba for contributing!

@azeemba azeemba deleted the patch-1 branch October 8, 2018 19:38
btmills added a commit that referenced this pull request Oct 12, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 7, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants