Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-invalid-regexp disallows \ at end of pattern (fixes #10861) #10920

Merged
merged 1 commit into from Oct 9, 2018

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix: fixes #10861.

What changes did you make? (Give an overview)

This PR upgrades regexpp package to 2.0.1 which fixed this bug (mysticatea/regexpp@0dc0b65), and adds a test case.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 5, 2018
@mysticatea mysticatea added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 5, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mysticatea mysticatea merged commit 5fe0e1a into master Oct 9, 2018
@mysticatea mysticatea deleted the issue10861 branch October 9, 2018 05:54
btmills added a commit that referenced this pull request Oct 12, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 8, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-invalid-regexp rule doesn't error with example from its documentation
4 participants