Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: iife statement type for padding-line-between-statements (fixes #10853) #10916

Merged
merged 1 commit into from Oct 12, 2018
Merged

Update: iife statement type for padding-line-between-statements (fixes #10853) #10916

merged 1 commit into from Oct 12, 2018

Conversation

platinumazure
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

See #10853.

What changes did you make? (Give an overview)

Added "iife" statement type to padding-line-between-statements rule.

Is there anything you'd like reviewers to focus on?

  • Any issues with the documentation changes I've added?
  • Are there any more tests I should add?

@platinumazure platinumazure added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 3, 2018
@platinumazure platinumazure self-assigned this Oct 3, 2018
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 4, 2018
@kaicataldo
Copy link
Member

#10853 has enough support from the team and this is now accepted.

btmills
btmills approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You weren't kidding on the issue when you said the implementation would be minimal 😆

not-an-aardvark
not-an-aardvark approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 6cb63fd into master Oct 12, 2018
@not-an-aardvark not-an-aardvark deleted the issue10853 branch October 12, 2018 19:03
btmills added a commit that referenced this pull request Oct 12, 2018
@btmills
Revert "Update: Add iife to padding-line-between-statements (fixes #1…
038f669 
…0853) (#10916)"

This reverts commit 6cb63fd.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 11, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees

@platinumazure platinumazure

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@platinumazure @kaicataldo @btmills @not-an-aardvark