Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Replace old note about caching with a new one considering autofixes (fixes #10739) #10913

Merged
merged 1 commit into from Oct 8, 2018
Merged

Docs: Replace old note about caching with a new one considering autofixes (fixes #10739) #10913

merged 1 commit into from Oct 8, 2018

Conversation

zacnomore
Copy link
Contributor

@zacnomore zacnomore commented Oct 3, 2018 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Removed old note and added new note per consideration from @platinumazure

Is there anything you'd like reviewers to focus on?
No.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 3, 2018
@zacnomore zacnomore mentioned this pull request Oct 3, 2018
Closed
@zacnomore zacnomore changed the title Replace old note about caching with a new one considering autofixes DOCS: Replace old note about caching with a new one considering autofixes Oct 3, 2018
@zacnomore zacnomore changed the title DOCS: Replace old note about caching with a new one considering autofixes Docs: Replace old note about caching with a new one considering autofixes Oct 3, 2018
@zacnomore zacnomore changed the title Docs: Replace old note about caching with a new one considering autofixes Docs: Replace old note about caching with a new one considering autofixes (fixes #10739) Oct 3, 2018
@platinumazure platinumazure added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 4, 2018
platinumazure
platinumazure approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like another set of eyes on this before merging.

@ilyavolodin ilyavolodin merged commit 557a8bb into eslint:master Oct 8, 2018
@platinumazure platinumazure mentioned this pull request Oct 8, 2018
Closed
btmills added a commit that referenced this pull request Oct 12, 2018
@btmills
Revert "Docs: Remove old note about caching, add a new one (fixes #10739
cca0328 
) (#10913)"

This reverts commit 557a8bb.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 7, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zacnomore @platinumazure @ilyavolodin