Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: table to version 5 #10903

Merged
merged 1 commit into from Oct 1, 2018
Merged

Upgrade: table to version 5 #10903

merged 1 commit into from Oct 1, 2018

Conversation

realityking
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Bumping table to its newest version. The breaking change is that version 5 requires Node.js 6.

Biggest advantage is that it loses a couple of dependencies, notably ajv-keywords - that disaster can't happen again 馃槅

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 29, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ilyavolodin ilyavolodin added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Oct 1, 2018
@not-an-aardvark not-an-aardvark merged commit 70bde69 into eslint:master Oct 1, 2018
@realityking realityking deleted the upgrade-table branch October 1, 2018 18:04
btmills added a commit that referenced this pull request Oct 12, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 31, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants