Chore: Update issue templates #10900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
|
Oops, need to get the security and question templates in. Please don't merge yet. |
|
I'm a bit confused. I see 4 new files, and then edits to 4 files that seem pretty similar conceptually. Put another way: For each of our 4 major issue template cases-- bug, new rule, rule change, non-rule change-- I'm seeing a new file and an edit to an existing file.) I don't understand what the relationship between each pair of files. Was the intent to replace one set of templates with the other? If so, should the other 4 files be deleted, not edited? Hopefully I'm just missing something simple. 😄 |
|
@platinumazure see my previous comment about the GitHub UI doing this. |
nzakas
force-pushed
the
issue-template-emoji
branch
from
5b8f033
to
30ae892
Compare
nzakas
added
chore
nzakas
changed the title
platinumazure
previously requested changes
Sep 27, 2018
ilyavolodin
approved these changes
Sep 28, 2018
gyandeeps
approved these changes
Sep 28, 2018
not-an-aardvark
approved these changes
Sep 28, 2018
* Add emoji to issue template selection screen for easier scanning. * Add Security issue template directing people to HackerOne * Add Question issue template directing people to mailing list and chatroom
nzakas
force-pushed
the
issue-template-emoji
branch
from
30ae892
to
d1e4792
Compare
not-an-aardvark
dismissed
platinumazure’s stale review
Comment has been addressed.
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add emoji to issue template selection screen for easier scanning.