Fix: avoid exponential require-atomic-updates traversal (fixes #10893) #10894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `no-atomic-updates` rule would traverse over every path in the control flow graph, resulting in a runtime that was exponential in the number of edges in the graph. This commit updates the rule to use a lattice-based [dataflow analysis](https://en.wikipedia.org/wiki/Data-flow_analysis) algorithm, similar to the algorithms used by optimizing compilers.
not-an-aardvark
added
bug
platinumazure
approved these changes
Sep 26, 2018
| @@ -68,7 +129,7 @@ ruleTester.run("require-atomic-updates", rule, { | |||
| errors: [VARIABLE_ERROR] | |||
| }, | |||
| { | |||
| code: "let foo; async function x() { foo = foo + (bar ? baz : await amount); }", | |||
| code: "let foo; async function x() { foo = foo + (barrr ? baz : await amount); }", | |||
There was a problem hiding this comment.
Not sure I understand the purpose of this change.
There was a problem hiding this comment.
Oops, this was accidental --- I temporarily changed it in order to be able to grep for a single test, but then I forgot to change it back.
not-an-aardvark
changed the title
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (#10893)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Previously, the
require-atomic-updatesrule would traverse over every path in the control flow graph, resulting in a runtime that was exponential in the number of edges in the graph. This commit updates the rule to use a lattice-based dataflow analysis algorithm, similar to the algorithms used by optimizing compilers.Is there anything you'd like reviewers to focus on?
Nothing in particular