Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: debug@4 (fixes #10854) #10887

Merged
merged 1 commit into from Sep 25, 2018
Merged

Upgrade: debug@4 (fixes #10854) #10887

merged 1 commit into from Sep 25, 2018

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Sep 23, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)
fixes #10854

Is there anything you'd like reviewers to focus on?

debug@4 drop node v4(should not break eslint)

@aladdin-add aladdin-add added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion upgrade This change is related to a dependency upgrade labels Sep 23, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like some more team members to review before merging. Thanks!

@platinumazure
Copy link
Member

@aladdin-add Oops, I didn't realize not-an-aardvark had already reviewed. I'm okay with this being merged in anytime.

@aladdin-add aladdin-add merged commit e51868d into master Sep 25, 2018
@aladdin-add aladdin-add deleted the Aladdin-ADD-patch-2 branch September 25, 2018 13:08
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 25, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade debug@4 dependency
3 participants