Fix: make separateRequires work in consecutive mode (fixes #10784) #10886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
g-plane
changed the title
aladdin-add
added
bug
aladdin-add
approved these changes
Sep 23, 2018
lib/rules/one-var.js
Outdated
| @@ -384,8 +384,13 @@ module.exports = { | |||
| if (nodeIndex > 0) { | |||
| const previousNode = parent.body[nodeIndex - 1]; | |||
| const isPreviousNodeDeclaration = previousNode.type === "VariableDeclaration"; | |||
| const declarationsWithPrevious = declarations.concat(isPreviousNodeDeclaration && previousNode.declarations); | |||
There was a problem hiding this comment.
nitpick: if isPreviousNodeDeclaration being false, it could be pushed to declarations. can we change it to something like:
const declarationsWithPrevious = declarations.concat(previousNode.declarations || []);
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (template)
What changes did you make? (Give an overview)
Fixes #10784