Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update quotes.md #10862

Merged
merged 1 commit into from Sep 19, 2018
Merged

Conversation

TheJaredWilcurt
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update

What changes did you make? (Give an overview)

allowTemplateLiterals: false is confusing, as users will expect it to prevent any usage of template literals. A note explaining that it does not do this has been added, along with a link to where to go for more information if that is their goal.

Is there anything you'd like reviewers to focus on?
The note explains that it doesn't do what user's would expect, but does not explain why. That context may be useful.

@jsf-clabot
Copy link

jsf-clabot commented Sep 16, 2018

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 16, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure
Copy link
Member

Note to maintainers: Add "Docs:" prefix on merge, unless commit summary is modified and force-pushed.

@TheJaredWilcurt TheJaredWilcurt changed the title Update quotes.md Docs: Update quotes.md Sep 16, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 4eb9a49 into eslint:master Sep 19, 2018
@TheJaredWilcurt TheJaredWilcurt deleted the patch-1 branch September 20, 2018 02:18
ch1ller0 pushed a commit to ch1ller0/eslint that referenced this pull request Sep 21, 2018
ch1ller0 pushed a commit to ch1ller0/eslint that referenced this pull request Sep 21, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 19, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants