Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation about Caching is outdated #10739

Closed
ajafff opened this issue Aug 6, 2018 · 2 comments
Closed

Documentation about Caching is outdated #10739

ajafff opened this issue Aug 6, 2018 · 2 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before

Comments

@ajafff
Copy link
Contributor

ajafff commented Aug 6, 2018

The version of ESLint you are using. v5.3.0

The problem you want to solve.

Since #10571 now also stores the result of failing files, the docs are no longer correct: https://eslint.org/docs/user-guide/command-line-interface#caching

Note:: As of now, only the results for successfully linted files are stored in the cache. Files which fail linting are not stored in the cache, so they will be linted every time.

Your take on the correct solution to problem.

Just remove this paragraph.
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 6, 2018
@platinumazure platinumazure added documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 6, 2018
@platinumazure
Copy link
Member

Hi @ajafff, thanks for the issue. This would definitely be a worthwhile change.

Would you like to submit a pull request?

ajafff added a commit to ajafff/eslint that referenced this issue Aug 6, 2018
@ajafff
Docs: remove outdated note about caching only valid files (fixes esli…
1a081be 
…nt#10739)
@ajafff
Copy link
Contributor Author

ajafff commented Aug 6, 2018

@platinumazure I just opened #10740 to fix this

btmills added a commit that referenced this issue Oct 12, 2018
@btmills
Revert "Docs: Remove old note about caching, add a new one (fixes #10739
cca0328 
) (#10913)"

This reverts commit 557a8bb.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 7, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@platinumazure @ajafff