Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some links are missing URL hashes on the website #10717

Closed
not-an-aardvark opened this issue Aug 1, 2018 · 0 comments
Closed

Some links are missing URL hashes on the website #10717

not-an-aardvark opened this issue Aug 1, 2018 · 0 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process

Comments

@not-an-aardvark
Copy link
Member

This link in the documentation has a URL hash hash of #ruletester, which is used as an anchor on the destination page. However, the corresponding generated link on the website does not have a URL hash, so when a user clicks that link on the website they will just end up at the top of the destination page.

This is happening because our build script deletes everything that follows .md in a relative link target, including a URL hash. Instead, the build script should just delete .md and not the text that follows.
@not-an-aardvark not-an-aardvark added bug ESLint is working incorrectly build This change relates to ESLint's build process accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 1, 2018
not-an-aardvark added a commit that referenced this issue Aug 2, 2018
@not-an-aardvark
Build: ensure URL fragments remain in documentation links (fixes #10717)
d34532e
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 30, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@not-an-aardvark