Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: remove links to terminated jscs.info domain #10706

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Docs: remove links to terminated jscs.info domain #10706

merged 2 commits into from
Aug 2, 2018

Conversation

pkuczynski
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I removed links to jscs.info domain, as they all lead to a site with info

The domain jscs.info is for sale. To purchase, call BuyDomains.com at 781-373-6841 or 844-896-7299. Click here for more details.

Is there anything you'd like reviewers to focus on?

Nope

@jsf-clabot
Copy link

jsf-clabot commented Jul 30, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 30, 2018
@pkuczynski pkuczynski changed the title Remove links to terminated jscs.info domain Docs: remove links to terminated jscs.info domain Jul 30, 2018
@aladdin-add aladdin-add added enhancement This change enhances an existing feature of ESLint documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 1, 2018
aladdin-add
aladdin-add approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pkuczynski
Copy link
Contributor Author

You welcome :)

@not-an-aardvark not-an-aardvark merged commit 6e78b7d into eslint:master Aug 2, 2018
@not-an-aardvark
Copy link
Member

Thanks!

@ghost
Copy link

ghost commented Aug 5, 2018

@not-an-aardvark not all instances were caught?

https://github.com/eslint/eslint/blob/master/docs/rules/padding-line-between-statements.md

@kaicataldo
Copy link
Member

@cup Thanks for the info!. Would you like to make a PR?

@kaicataldo kaicataldo mentioned this pull request Aug 5, 2018
Closed
@pkuczynski
Copy link
Contributor Author

I will fire up a PR in a sec...

@pkuczynski pkuczynski deleted the remove-jscs branch August 6, 2018 11:30
@pkuczynski pkuczynski mentioned this pull request Aug 6, 2018
Closed
@santanaG santanaG mentioned this pull request Aug 17, 2018
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 30, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkuczynski @jsf-clabot @not-an-aardvark @kaicataldo @aladdin-add